Skip to content

Check for multiple targets that are compiled #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 17, 2025
Merged

Check for multiple targets that are compiled #423

merged 5 commits into from
Jul 17, 2025

Conversation

buenaflor
Copy link
Contributor

In tests there could be multiple targets being compiled so let's just look for all that are in the task graph

@buenaflor buenaflor requested a review from romtsn as a code owner July 16, 2025 14:10
Comment on lines 8 to 13
paths:
- '.github/workflows/kotlin-multiplatform.yml'
- 'kotlin-multiplatform/**'
- 'sentry-samples/**'
- 'buildSrc/src/'
- '!**/*.md'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only temporary for testing, will be removed before merging

Copy link
Contributor Author

@buenaflor buenaflor Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted it already: verified that it works

Copy link

codecov bot commented Jul 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.29%. Comparing base (3a6a14a) to head (49705d8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...sentry/kotlin/multiplatform/gradle/SentryPlugin.kt 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
- Coverage   78.29%   75.29%   -3.01%     
==========================================
  Files          44       11      -33     
  Lines         834      344     -490     
  Branches      113       52      -61     
==========================================
- Hits          653      259     -394     
+ Misses        125       57      -68     
+ Partials       56       28      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@buenaflor buenaflor merged commit f66bea3 into main Jul 17, 2025
8 of 10 checks passed
@buenaflor buenaflor deleted the fix/tests branch July 17, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants